lkml.org 
[lkml]   [2019]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] powerpc/mm: move a KERN_WARNING message to KERN_DEBUG
From
Date


Le 05/02/2019 à 19:03, Laurent Vivier a écrit :
> resize_hpt_for_hotplug() reports a warning when it cannot
> increase the hash page table ("Unable to resize hash page
> table to target order") but this is not blocking and
> can make user thinks something has not worked properly.
>
> If the operation cannot be done the real error message
> will be reported by arch_add_memory() if create_section_mapping()
> fails.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> arch/powerpc/mm/hash_utils_64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
> index 0cc7fbc3bd1c..b762bdceb510 100644
> --- a/arch/powerpc/mm/hash_utils_64.c
> +++ b/arch/powerpc/mm/hash_utils_64.c
> @@ -778,7 +778,7 @@ void resize_hpt_for_hotplug(unsigned long new_mem_size)
>
> rc = mmu_hash_ops.resize_hpt(target_hpt_shift);
> if (rc && (rc != -ENODEV))
> - printk(KERN_WARNING
> + printk(KERN_DEBUG

You should use pr_debug() instead.

Christophe

> "Unable to resize hash page table to target order %d: %d\n",
> target_hpt_shift, rc);
> }
>

\
 
 \ /
  Last update: 2019-02-05 19:12    [W:0.042 / U:6.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site