lkml.org 
[lkml]   [2019]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 5/5] arm: dts: axpxx: add charge led node
On Thu, Jan 31, 2019 at 4:25 PM Stefan Mavrodiev <stefan@olimex.com> wrote:
>
> Add dt node for axp20x-led driver controlling CHGLED.
> Default status is disabled, since it may be not used.
>
> Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>

Please include a cover letter for such a patch series.

Also, do any boards actually use this? I know the Pine64 does, but the
LED is left to the user to populate. I would really like to have an in
kernel user of this function, so that we can verify it.

ChenYu

> ---
> arch/arm/boot/dts/axp209.dtsi | 5 +++++
> arch/arm/boot/dts/axp22x.dtsi | 5 +++++
> arch/arm/boot/dts/axp81x.dtsi | 5 +++++
> 3 files changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/axp209.dtsi b/arch/arm/boot/dts/axp209.dtsi
> index 0d9ff12bdf28..f972b6f3ecd0 100644
> --- a/arch/arm/boot/dts/axp209.dtsi
> +++ b/arch/arm/boot/dts/axp209.dtsi
> @@ -69,6 +69,11 @@
> #gpio-cells = <2>;
> };
>
> + axp_led: led {
> + compatible = "x-powers,axp20x-led";
> + status = "disabled";
> + };
> +
> battery_power_supply: battery-power-supply {
> compatible = "x-powers,axp209-battery-power-supply";
> status = "disabled";
> diff --git a/arch/arm/boot/dts/axp22x.dtsi b/arch/arm/boot/dts/axp22x.dtsi
> index 65a07a67aca9..92a0b64252b1 100644
> --- a/arch/arm/boot/dts/axp22x.dtsi
> +++ b/arch/arm/boot/dts/axp22x.dtsi
> @@ -62,6 +62,11 @@
> #io-channel-cells = <1>;
> };
>
> + axp_led: led {
> + compatible = "x-powers,axp20x-led";
> + status = "disabled";
> + };
> +
> battery_power_supply: battery-power-supply {
> compatible = "x-powers,axp221-battery-power-supply";
> status = "disabled";
> diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi
> index bd83962d3627..22e243cc40d5 100644
> --- a/arch/arm/boot/dts/axp81x.dtsi
> +++ b/arch/arm/boot/dts/axp81x.dtsi
> @@ -74,6 +74,11 @@
> };
> };
>
> + axp_led: led {
> + compatible = "x-powers,axp20x-led";
> + status = "disabled";
> + };
> +
> battery_power_supply: battery-power-supply {
> compatible = "x-powers,axp813-battery-power-supply";
> status = "disabled";
> --
> 2.17.1
>

\
 
 \ /
  Last update: 2019-02-05 17:17    [W:0.092 / U:14.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site