Messages in this thread | | | Subject | Re: [PATCH] build_bug.h: add wrapper for _Static_assert | From | Rasmus Villemoes <> | Date | Tue, 5 Feb 2019 10:53:31 +0100 |
| |
On 05/02/2019 00.12, Andrew Morton wrote: >> >> It would be (very) nice to actually use this macro in a few places so >> it gets its build testing while in -next. > > ie, just about every BUILD_BUG_ON in mm/ could use this. Let's switch > a few? >
Perhaps, but some make sense where they are, e.g. when iterating over two arrays using one iterator variable, it's fine to assert they have the same size just above the loop. And, unfortunately, static_assert() is not quite a drop-in replacement for BUILD_BUG_ON even when the argument is an ICE due to -Wdeclaration-after-statement.
I'll fix the two BUILD_BUGs I know I've added over the years (one in vsprintf.c, one in fs/namei.c).
Rasmus
| |