Messages in this thread | | | Date | Mon, 4 Feb 2019 06:57:36 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH v4 14/16] block: sed-opal: pass steps via argument rather than via opal_dev |
| |
On Fri, Feb 01, 2019 at 09:50:21PM +0100, David Kozub wrote: > The steps argument is only read by the next function, so it can > be passed directly as an argument rather than via opal_dev. > > Normally, the steps is an array on the stack, so the pointer stops > being valid then the function that set opal_dev.steps returns. > If opal_dev.steps was not set to NULL before return it would become > a dangling pointer. When the steps are passed as argument this > becomes easier to see and more difficult to misuse. > > Signed-off-by: David Kozub <zub@linux.fjfi.cvut.cz> > Reviewed-by: Scott Bauer <sbauer@plzdonthack.me>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |