lkml.org 
[lkml]   [2019]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/3] perf tools: Move ipc_symbol computation to resort
Date
hi,
currently the we make annotation for ipc column during the
entry display, already outside the progress bar scope, so
it appears like perf report is stuck.

You can see that on following example (with perf.data big enough):
$ perf record -b ...
$ perf report -s symbol

The report TUI code will appear stuck when scrolling down,
because annotation are computed at that time. For --stdio,
the output will be displayed noticeably more slowly, than
with the fix.

There's no functional change, I'm just moving the annotation
retrieval to the resort phase, so all the data are ready for
display.

thanks,
jirka


---
Jiri Olsa (3):
perf tools: Add argument to hists__resort_cb_t callback
perf tools: Add perf_evsel__output_resort_cb function
perf tools: Move symbol annotation to resort

tools/perf/builtin-c2c.c | 8 ++++----
tools/perf/builtin-report.c | 21 +++++++++++++++++++--
tools/perf/util/hist.c | 19 +++++++++++++------
tools/perf/util/hist.h | 4 +++-
tools/perf/util/sort.c | 7 -------
5 files changed, 39 insertions(+), 20 deletions(-)

\
 
 \ /
  Last update: 2019-02-04 15:18    [W:0.067 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site