lkml.org 
[lkml]   [2019]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 46/74] gpiolib: fix line event timestamps for nested irqs
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

    commit 1033be58992f818dc564196ded2bcc3f360bc297 upstream.

    Nested interrupts run inside the calling thread's context and the top
    half handler is never called which means that we never read the
    timestamp.

    This issue came up when trying to read line events from a gpiochip
    using regmap_irq_chip for interrupts.

    Fix it by reading the timestamp from the irq thread function if it's
    still 0 by the time the second handler is called.

    Fixes: d58f2bf261fd ("gpio: Timestamp events in hardirq handler")
    Cc: stable@vger.kernel.org
    Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


    ---
    drivers/gpio/gpiolib.c | 10 +++++++++-
    1 file changed, 9 insertions(+), 1 deletion(-)

    --- a/drivers/gpio/gpiolib.c
    +++ b/drivers/gpio/gpiolib.c
    @@ -817,7 +817,15 @@ static irqreturn_t lineevent_irq_thread(
    /* Do not leak kernel stack to userspace */
    memset(&ge, 0, sizeof(ge));

    - ge.timestamp = le->timestamp;
    + /*
    + * We may be running from a nested threaded interrupt in which case
    + * we didn't get the timestamp from lineevent_irq_handler().
    + */
    + if (!le->timestamp)
    + ge.timestamp = ktime_get_real_ns();
    + else
    + ge.timestamp = le->timestamp;
    +
    level = gpiod_get_value_cansleep(le->desc);

    if (le->eflags & GPIOEVENT_REQUEST_RISING_EDGE

    \
     
     \ /
      Last update: 2019-02-04 12:00    [W:4.440 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site