lkml.org 
[lkml]   [2019]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 09/65] ASoC: atom: fix a missing check of snd_pcm_lib_malloc_pages
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Kangjie Lu <kjlu@umn.edu>

    commit 44fabd8cdaaa3acb80ad2bb3b5c61ae2136af661 upstream.

    snd_pcm_lib_malloc_pages() may fail, so let's check its status and
    return its error code upstream.

    Signed-off-by: Kangjie Lu <kjlu@umn.edu>
    Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Cc: stable@vger.kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/soc/intel/atom/sst-mfld-platform-pcm.c | 8 +++++++-
    1 file changed, 7 insertions(+), 1 deletion(-)

    --- a/sound/soc/intel/atom/sst-mfld-platform-pcm.c
    +++ b/sound/soc/intel/atom/sst-mfld-platform-pcm.c
    @@ -398,7 +398,13 @@ static int sst_media_hw_params(struct sn
    struct snd_pcm_hw_params *params,
    struct snd_soc_dai *dai)
    {
    - snd_pcm_lib_malloc_pages(substream, params_buffer_bytes(params));
    + int ret;
    +
    + ret =
    + snd_pcm_lib_malloc_pages(substream,
    + params_buffer_bytes(params));
    + if (ret)
    + return ret;
    memset(substream->runtime->dma_area, 0, params_buffer_bytes(params));
    return 0;
    }

    \
     
     \ /
      Last update: 2019-02-04 11:40    [W:4.184 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site