lkml.org 
[lkml]   [2019]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 04/12] ARM: davinci: WARN_ON() if clk_get() fails
From
Date
On 2/4/19 11:17 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Currently the timer code checks if the clock pointer passed to it is
> good (!IS_ERR(clk)). The new clocksource driver expects the clock to
> be functional and doesn't perform any checks so emit a warning if
> clk_get() fails. Apply this to all davinci platforms.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> arch/arm/mach-davinci/da830.c | 4 ++++
> arch/arm/mach-davinci/da850.c | 4 ++++
> arch/arm/mach-davinci/dm355.c | 4 ++++
> arch/arm/mach-davinci/dm365.c | 4 ++++
> arch/arm/mach-davinci/dm644x.c | 4 ++++
> arch/arm/mach-davinci/dm646x.c | 4 ++++
> 6 files changed, 24 insertions(+)
>
> diff --git a/arch/arm/mach-davinci/da830.c b/arch/arm/mach-davinci/da830.c
> index 2cc9fe4c3a91..9a4b749cbb6b 100644
> --- a/arch/arm/mach-davinci/da830.c
> +++ b/arch/arm/mach-davinci/da830.c
> @@ -834,6 +834,10 @@ void __init da830_init_time(void)
> da830_pll_init(NULL, pll, NULL);
>
> clk = clk_get(NULL, "timer0");
> + if (WARN_ON(IS_ERR(clk))) {
> + pr_err("Unable to get the timer clock\n");

Do we really need a warning _and_ an error?

> + return;
> + }
>
> davinci_timer_init(clk);
> }

\
 
 \ /
  Last update: 2019-02-05 03:18    [W:0.418 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site