| Subject | Re: [PATCH 08/35] ARM: davinci: select SPARSE_IRQ | From | David Lechner <> | Date | Mon, 4 Feb 2019 16:46:16 -0600 |
| |
On 1/31/19 7:39 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > Everything is in place now for SPARSE_IRQ. Select it and set > DAVINCI_INTC_START to NR_IRQS. > > We now need to include mach/irqs.h in a couple places as it is no > longer indirectly included after selecting SPARSE_IRQ. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > ---
Reviewed-by: David Lechner <david@lechnology.com>
...
> diff --git a/arch/arm/mach-davinci/include/mach/irqs.h b/arch/arm/mach-davinci/include/mach/irqs.h > index 14fa668d4e8d..317cbc42e5cd 100644 > --- a/arch/arm/mach-davinci/include/mach/irqs.h > +++ b/arch/arm/mach-davinci/include/mach/irqs.h > @@ -27,10 +27,12 @@ > #ifndef __ASM_ARCH_IRQS_H > #define __ASM_ARCH_IRQS_H > > +#include <asm/irq.h> > + > /* Base address */ > #define DAVINCI_ARM_INTC_BASE 0x01C48000 > > -#define DAVINCI_INTC_START 0 > +#define DAVINCI_INTC_START NR_IRQS > #define DAVINCI_INTC_IRQ(_irqnum) (DAVINCI_INTC_START + (_irqnum)) > > /* Interrupt lines */ > @@ -404,6 +406,5 @@ > /* da850 currently has the most gpio pins (144) */ > #define DAVINCI_N_GPIO 144 > /* da850 currently has the most irqs so use DA850_N_CP_INTC_IRQ */
It would make sense to delete this comment in this patch as well (although it gets deleted later anyway).
> -#define NR_IRQS (DA850_N_CP_INTC_IRQ + DAVINCI_N_GPIO) > > #endif /* __ASM_ARCH_IRQS_H */
|