Messages in this thread Patch in this message | | | Date | Sun, 3 Feb 2019 13:21:58 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 5/5] EDAC, mce_amd: Print ExtErrorCode and description on a single line |
| |
On Fri, Feb 01, 2019 at 10:55:54PM +0000, Ghannam, Yazen wrote: > From: Yazen Ghannam <yazen.ghannam@amd.com> > > Save a log line by printing the extended error code and the description > on a single line. This is similar to how errors are printed in other > subsystems, e.g. "#, description". If we don't have a valid description > then only the number/code is printed. > > Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com> > --- > drivers/edac/mce_amd.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c > index 7e29ceabdf6f..f286b880f981 100644 > --- a/drivers/edac/mce_amd.c > +++ b/drivers/edac/mce_amd.c > @@ -965,13 +965,12 @@ static void decode_smca_error(struct mce *m) > > ip_name = smca_get_long_name(bank_type); > > - pr_emerg(HW_ERR "%s Extended Error Code: %d\n", ip_name, xec); > + pr_emerg(HW_ERR "%s Ext. Error Code: %d", ip_name, xec); > > /* Only print the decode of valid error codes */ > if (xec < smca_mce_descs[bank_type].num_descs && > (hwid->xec_bitmap & BIT_ULL(xec))) { > - pr_emerg(HW_ERR "%s Error: ", ip_name); > - pr_cont("%s.\n", smca_mce_descs[bank_type].descs[xec]); > + pr_cont(", %s.\n", smca_mce_descs[bank_type].descs[xec]);
If the if-condition doesn't hit, we never print the \n
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |