lkml.org 
[lkml]   [2019]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 114/305] thermal: rcar_thermal: Prevent hardware access during system suspend
    3.16.63-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Geert Uytterhoeven <geert+renesas@glider.be>

    commit 3a31386217628ffe2491695be2db933c25dde785 upstream.

    On r8a7791/koelsch, sometimes the following message is printed during
    system suspend:

    rcar_thermal e61f0000.thermal: thermal sensor was broken

    This happens if the workqueue runs while the device is already
    suspended. Fix this by using the freezable system workqueue instead,
    cfr. commit 51e20d0e3a60cf46 ("thermal: Prevent polling from happening
    during system suspend").

    Fixes: e0a5172e9eec7f0d ("thermal: rcar: add interrupt support")
    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
    Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/thermal/rcar_thermal.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/thermal/rcar_thermal.c
    +++ b/drivers/thermal/rcar_thermal.c
    @@ -351,8 +351,8 @@ static irqreturn_t rcar_thermal_irq(int
    rcar_thermal_for_each_priv(priv, common) {
    if (rcar_thermal_had_changed(priv, status)) {
    rcar_thermal_irq_disable(priv);
    - schedule_delayed_work(&priv->work,
    - msecs_to_jiffies(300));
    + queue_delayed_work(system_freezable_wq, &priv->work,
    + msecs_to_jiffies(300));
    }
    }

    \
     
     \ /
      Last update: 2019-02-03 15:32    [W:2.222 / U:1.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site