lkml.org 
[lkml]   [2019]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 100/305] xfs: Fix xqmstats offsets in /proc/fs/xfs/xqmstat
    3.16.63-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Carlos Maiolino <cmaiolino@redhat.com>

    commit 41657e5507b13e963be906d5d874f4f02374fd5c upstream.

    The addition of FIBT, RMAP and REFCOUNT changed the offsets into
    __xfssats structure.

    This caused xqmstat_proc_show() to display garbage data via
    /proc/fs/xfs/xqmstat, once it relies on the offsets marked via macros.

    Fix it.

    Fixes: 00f4e4f9 xfs: add rmap btree stats infrastructure
    Fixes: aafc3c24 xfs: support the XFS_BTNUM_FINOBT free inode btree type
    Fixes: 46eeb521 xfs: introduce refcount btree definitions
    Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
    Reviewed-by: Eric Sandeen <sandeen@redhat.com>
    Signed-off-by: Dave Chinner <david@fromorbit.com>
    [bwh: Backported to 3.16:
    - Only the FIBT stats have been added, so start from XFSSTAT_END_FIBT_V2
    - Adjust context]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/xfs/xfs_stats.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/xfs/xfs_stats.c
    +++ b/fs/xfs/xfs_stats.c
    @@ -135,7 +135,7 @@ static int xqmstat_proc_show(struct seq_
    int j;

    seq_printf(m, "qm");
    - for (j = XFSSTAT_END_IBT_V2; j < XFSSTAT_END_XQMSTAT; j++)
    + for (j = XFSSTAT_END_FIBT_V2; j < XFSSTAT_END_XQMSTAT; j++)
    seq_printf(m, " %u", counter_val(j));
    seq_putc(m, '\n');
    return 0;
    \
     
     \ /
      Last update: 2019-02-03 15:03    [W:4.053 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site