lkml.org 
[lkml]   [2019]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 267/305] cifs: Fix separator when building path from dentry
    3.16.63-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Paulo Alcantara <palcantara@suse.com>

    commit c988de29ca161823db6a7125e803d597ef75b49c upstream.

    Make sure to use the CIFS_DIR_SEP(cifs_sb) as path separator for
    prefixpath too. Fixes a bug with smb1 UNIX extensions.

    Fixes: a6b5058fafdf ("fs/cifs: make share unaccessible at root level mountable")
    Signed-off-by: Paulo Alcantara <palcantara@suse.com>
    Reviewed-by: Aurelien Aptel <aaptel@suse.com>
    Signed-off-by: Steve French <stfrench@microsoft.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/cifs/dir.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/cifs/dir.c
    +++ b/fs/cifs/dir.c
    @@ -163,7 +163,7 @@ cifs_bp_rename_retry:

    cifs_dbg(FYI, "using cifs_sb prepath <%s>\n", cifs_sb->prepath);
    memcpy(full_path+dfsplen+1, cifs_sb->prepath, pplen-1);
    - full_path[dfsplen] = '\\';
    + full_path[dfsplen] = dirsep;
    for (i = 0; i < pplen-1; i++)
    if (full_path[dfsplen+1+i] == '/')
    full_path[dfsplen+1+i] = CIFS_DIR_SEP(cifs_sb);
    \
     
     \ /
      Last update: 2019-02-03 14:56    [W:4.025 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site