Messages in this thread | | | From | Fabio Estevam <> | Date | Thu, 28 Feb 2019 15:40:12 -0300 | Subject | Re: [PATCH v4 5/5] arm64: dts: imx8mq-evk: Enable wm8524 codec |
| |
On Wed, Feb 27, 2019 at 3:38 AM Daniel Baluta <daniel.baluta@nxp.com> wrote:
> + > + wm8524: audio-codec-0 {
This -0 is not needed as we have a single codec on this board.
> + #sound-dai-cells = <0>; > + compatible = "wlf,wm8524"; > + clocks = <&clk IMX8MQ_CLK_SAI2_ROOT>; > + clock-names = "mclk";
The clocks and clock-names properties can be removed, right?
I don't see them defined in the binding doc and the codec driver does not call clk_get(), so there is a mismatch.
Also, I still think this one and the previous patch could be made into a single patch that adds audio support for the board.
| |