Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH v5 04/10] crypto: akcipher - new verify API for public key algorithms | Date | Thu, 28 Feb 2019 18:18:54 +0000 |
| |
Vitaly Chikunov <vt@altlinux.org> wrote:
> + digest = kmemdup(sig->digest, sig->digest_size, GFP_KERNEL); > + if (!digest)
You shouldn't need to copy the digest. It's being passed in to the crypto algorithm, not extracted out.
> + if (memcmp(c, outbuf_enc, c_size)) {
Please use == 0 and != 0 with memcmp() and strcmp(). Their return values are kind of inverted in sense if you treat them as boolean.
David
| |