lkml.org 
[lkml]   [2019]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] watchdog: pc87413: Mark expected switch fall-through
From
Date


On 2/26/19 11:55 AM, Guenter Roeck wrote:
> On Tue, Feb 26, 2019 at 11:46:09AM -0600, Gustavo A. R. Silva wrote:
>> Hi all,
>>
>> Friendly ping:
>>
>> Who can take this?
>>
> Wim, presumably.
>

Oh OK. Hopefully, he'll notice this thread soon.

Thanks
--
Gustavo


> Guenter
>
>> Thanks
>> --
>> Gustavo
>>
>>
>> On 2/18/19 11:50 AM, Gustavo A. R. Silva wrote:
>>>
>>>
>>> On 2/18/19 10:09 AM, Guenter Roeck wrote:
>>>> On 2/14/19 12:26 PM, Gustavo A. R. Silva wrote:
>>>>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>>>>> cases where we are expecting to fall through.
>>>>>
>>>>> This patch fixes the following warning:
>>>>>
>>>>> drivers/watchdog/pc87413_wdt.c: In function ‘pc87413_ioctl’:
>>>>> drivers/watchdog/pc87413_wdt.c:439:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>>>>     pc87413_refresh();
>>>>>     ^~~~~~~~~~~~~~~~~
>>>>> drivers/watchdog/pc87413_wdt.c:441:2: note: here
>>>>>    case WDIOC_GETTIMEOUT:
>>>>>    ^~~~
>>>>>
>>>>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>>>>
>>>>> Notice that, in this particular case, the code comment is modified
>>>>> in accordance with what GCC is expecting to find.
>>>>>
>>>>> This patch is part of the ongoing efforts to enable
>>>>> -Wimplicit-fallthrough.
>>>>>
>>>>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>>>
>>>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>>>
>>>
>>> Thanks, Guenter.
>>>
>>> --
>>> Gustavo
>>>

\
 
 \ /
  Last update: 2019-02-26 19:11    [W:0.099 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site