lkml.org 
[lkml]   [2019]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] Bluetooth: hci_qca: Pass boolean 'on/off' to qca_send_power_pulse()
On 2019-02-26 05:19, Matthias Kaehlcke wrote:
> There are only two types of power pulses 'on' or 'off', pass a boolean
> instead of the power pulse 'command'.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> drivers/bluetooth/hci_qca.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 5e03504c4e0ca..e4128774e9686 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -1004,10 +1004,11 @@ static inline void host_set_baudrate(struct
> hci_uart *hu, unsigned int speed)
> hci_uart_set_baudrate(hu, speed);
> }
>
> -static int qca_send_power_pulse(struct hci_uart *hu, u8 cmd)
> +static int qca_send_power_pulse(struct hci_uart *hu, bool on)
> {
> int ret;
> int timeout = msecs_to_jiffies(POWER_PULSE_TRANS_TIMEOUT_MS);
> + u8 cmd = on ? QCA_WCN3990_POWERON_PULSE : QCA_WCN3990_POWEROFF_PULSE;
>
> /* These power pulses are single byte command which are sent
> * at required baudrate to wcn3990. On wcn3990, we have an external
> @@ -1138,12 +1139,12 @@ static int qca_wcn3990_init(struct hci_uart
> *hu)
>
> /* Forcefully enable wcn3990 to enter in to boot mode. */
> host_set_baudrate(hu, 2400);
> - ret = qca_send_power_pulse(hu, QCA_WCN3990_POWEROFF_PULSE);
> + ret = qca_send_power_pulse(hu, false);
> if (ret)
> return ret;
>
> qca_set_speed(hu, QCA_INIT_SPEED);
> - ret = qca_send_power_pulse(hu, QCA_WCN3990_POWERON_PULSE);
> + ret = qca_send_power_pulse(hu, true);
> if (ret)
> return ret;
>
> @@ -1289,7 +1290,7 @@ static void qca_power_shutdown(struct hci_uart
> *hu)
> spin_unlock_irqrestore(&qca->hci_ibs_lock, flags);
>
> host_set_baudrate(hu, 2400);
> - qca_send_power_pulse(hu, QCA_WCN3990_POWEROFF_PULSE);
> + qca_send_power_pulse(hu, false);
> qca_power_setup(hu, false);
> }

Reviewed-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>

--
Regards
Balakrishna.

\
 
 \ /
  Last update: 2019-02-26 13:17    [W:0.063 / U:1.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site