Messages in this thread | | | Subject | Re: [PATCH] parport: ieee1284: mark expected switch fall-through | From | "Gustavo A. R. Silva" <> | Date | Mon, 25 Feb 2019 12:23:32 -0600 |
| |
Hi,
Friendly ping:
Who can take this, please?
Thanks -- Gustavo
On 2/12/19 11:43 AM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/parport/ieee1284.c: In function ‘parport_read’: > drivers/parport/ieee1284.c:722:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (parport_negotiate (port, IEEE1284_MODE_NIBBLE)) { > ^ > drivers/parport/ieee1284.c:726:2: note: here > case IEEE1284_MODE_NIBBLE: > ^~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > Notice that, in this particular case, the code comment is modified > in accordance with what GCC is expecting to find. > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/parport/ieee1284.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/parport/ieee1284.c b/drivers/parport/ieee1284.c > index f12b9da69255..90fb73575495 100644 > --- a/drivers/parport/ieee1284.c > +++ b/drivers/parport/ieee1284.c > @@ -722,7 +722,7 @@ ssize_t parport_read (struct parport *port, void *buffer, size_t len) > if (parport_negotiate (port, IEEE1284_MODE_NIBBLE)) { > return -EIO; > } > - /* fall through to NIBBLE */ > + /* fall through - to NIBBLE */ > case IEEE1284_MODE_NIBBLE: > DPRINTK (KERN_DEBUG "%s: Using nibble mode\n", port->name); > fn = port->ops->nibble_read_data; >
| |