Messages in this thread | | | Date | Mon, 25 Feb 2019 05:33:35 -0800 | From | Andi Kleen <> | Subject | Re: [PATCH 11/11] perf tools report: Implement browsing of individual samples |
| |
On Mon, Feb 25, 2019 at 01:56:15PM +0100, Jiri Olsa wrote: > On Sun, Feb 24, 2019 at 07:37:22AM -0800, Andi Kleen wrote: > > SNIP > > > +static void hists__res_sample(struct hist_entry *he, struct perf_sample *sample) > > +{ > > + struct res_sample *r; > > + int j; > > + > > + if (!he->res_samples) { > > + he->res_samples = calloc(sizeof(struct res_sample), > > + symbol_conf.res_sample); > > + if (!he->res_samples) > > + return; > > + } > > + if (he->num_res < symbol_conf.res_sample) { > > + j = he->num_res++; > > + } else { > > + j = random_max(++he->num_res + 1); > > will he->num_res keep raising all the time?
Yes, but the display code limits it to symbol_conf.res_samples
That was intentional so that we can keep track of the total number of samples. Plan was to eventually display it somewhere so that the users know how many of the samples are covered (currently it is not though)
-Andi
| |