Messages in this thread | | | Date | Mon, 25 Feb 2019 13:55:33 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 06/11] perf tools report: Use less for scripts output |
| |
On Sun, Feb 24, 2019 at 07:37:17AM -0800, Andi Kleen wrote: > From: Andi Kleen <ak@linux.intel.com> > > The UI viewer for scripts output has a lot of limitations: limited size, > no search or save function, slow, and various other issues. > > Just use 'less' to display directly on the terminal instead. > > This won't work in gtk mode, but gtk doesn't support these > context menus anyways. If that is every done could use an terminal > for the output. > > Signed-off-by: Andi Kleen <ak@linux.intel.com> > --- > tools/perf/ui/browsers/scripts.c | 125 +++++-------------------------- > 1 file changed, 17 insertions(+), 108 deletions(-)
I like the stats ;-)
I assume some of the current includes can be removed as well:
#include <elf.h> #include <inttypes.h> #include <sys/ttydefaults.h> #include <string.h> #include "../../util/sort.h" #include "../../util/util.h" #include "../../util/hist.h" #include "../../util/debug.h" #include "../../util/symbol.h" #include "../browser.h" #include "../helpline.h" #include "../libslang.h"
jirka
| |