[lkml]   [2019]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 4.9 42/63] hpet: Make cmd parameter of hpet_ioctl_common() unsigned
4.9-stable review patch.  If anyone has any objections, please let me know.


From: Matthias Kaehlcke <>

commit 5cd5e6ad0ede862432e1e766bfe02a9ad447533e upstream.

The value passed by the two callers of the function is unsigned anyway.

Making the parameter unsigned fixes the following warning when building
with clang:

drivers/char/hpet.c:588:7: error: overflow converting case value to switch condition type (2149083139 to 18446744071563667459) [-Werror,-Wswitch]
include/uapi/linux/hpet.h:18:19: note: expanded from macro 'HPET_INFO'
include/uapi/asm-generic/ioctl.h:77:28: note: expanded from macro '_IOR'
include/uapi/asm-generic/ioctl.h:66:2: note: expanded from macro '_IOC'
(((dir) << _IOC_DIRSHIFT) | \

Signed-off-by: Matthias Kaehlcke <>
Acked-by: Clemens Ladisch <>
Signed-off-by: Greg Kroah-Hartman <>
Signed-off-by: Nathan Chancellor <>
Signed-off-by: Greg Kroah-Hartman <>
drivers/char/hpet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -574,7 +574,7 @@ static inline unsigned long hpet_time_di

static int
-hpet_ioctl_common(struct hpet_dev *devp, int cmd, unsigned long arg,
+hpet_ioctl_common(struct hpet_dev *devp, unsigned int cmd, unsigned long arg,
struct hpet_info *info)
struct hpet_timer __iomem *timer;

 \ /
  Last update: 2019-02-25 23:03    [W:0.251 / U:3.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site