lkml.org 
[lkml]   [2019]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 65/65] autofs: fix error return in autofs_fill_super()
    Date
    From: Ian Kent <raven@themaw.net>

    [ Upstream commit f585b283e3f025754c45bbe7533fc6e5c4643700 ]

    In autofs_fill_super() on error of get inode/make root dentry the return
    should be ENOMEM as this is the only failure case of the called
    functions.

    Link: http://lkml.kernel.org/r/154725123240.11260.796773942606871359.stgit@pluto-themaw-net
    Signed-off-by: Ian Kent <raven@themaw.net>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/autofs/inode.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/fs/autofs/inode.c b/fs/autofs/inode.c
    index 846c052569dd4..3c14a8e45ffb6 100644
    --- a/fs/autofs/inode.c
    +++ b/fs/autofs/inode.c
    @@ -255,8 +255,10 @@ int autofs_fill_super(struct super_block *s, void *data, int silent)
    }
    root_inode = autofs_get_inode(s, S_IFDIR | 0755);
    root = d_make_root(root_inode);
    - if (!root)
    + if (!root) {
    + ret = -ENOMEM;
    goto fail_ino;
    + }
    pipe = NULL;

    root->d_fsdata = ino;
    --
    2.19.1
    \
     
     \ /
      Last update: 2019-02-23 22:23    [W:4.134 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site