lkml.org 
[lkml]   [2019]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 11/12] ARM: OMAP2+: add missing of_node_put after of_device_is_available
    Date
    Add an of_node_put when a tested device node is not available.

    The semantic patch that fixes this problem is as follows
    (http://coccinelle.lip6.fr):

    // <smpl>
    @@
    identifier f;
    local idexpression e;
    expression x;
    @@

    e = f(...);
    ... when != of_node_put(e)
    when != x = e
    when != e = x
    when any
    if (<+...of_device_is_available(e)...+>) {
    ... when != of_node_put(e)
    (
    return e;
    |
    + of_node_put(e);
    return ...;
    )
    }
    // </smpl>

    Fixes: e0c827aca0730 ("drm/omap: Populate DSS children in omapdss driver")
    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    arch/arm/mach-omap2/display.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff -u -p a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c
    --- a/arch/arm/mach-omap2/display.c
    +++ b/arch/arm/mach-omap2/display.c
    @@ -250,8 +250,10 @@ static int __init omapdss_init_of(void)
    if (!node)
    return 0;

    - if (!of_device_is_available(node))
    + if (!of_device_is_available(node)) {
    + of_node_put(node);
    return 0;
    + }

    pdev = of_find_device_by_node(node);

    \
     
     \ /
      Last update: 2019-02-23 20:31    [W:4.612 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site