Messages in this thread | | | Subject | Re: [RESEND PATCH v2 2/2] selftests/ftrace: Replace \e with \033 | From | shuah <> | Date | Fri, 22 Feb 2019 15:46:03 -0700 |
| |
On 2/22/19 1:53 PM, Juerg Haefliger wrote: > The \e sequence character is not POSIX. Fix that by using \033 instead. > > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org> > Acked-by: Masami Hiramatsu <mhiramat@kernel.org> > Signed-off-by: Juerg Haefliger <juergh@canonical.com> > --- > tools/testing/selftests/ftrace/ftracetest | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest > index 20c9c0ad8682..136387422b00 100755 > --- a/tools/testing/selftests/ftrace/ftracetest > +++ b/tools/testing/selftests/ftrace/ftracetest > @@ -161,10 +161,10 @@ color_green= > color_blue= > # If stdout exists and number of colors is eight or more, use them > if [ -t 1 -a "$ncolors" -ge 8 ]; then > - color_reset="\e[0m" > - color_red="\e[31m" > - color_green="\e[32m" > - color_blue="\e[34m" > + color_reset="\033[0m" > + color_red="\033[31m" > + color_green="\033[32m" > + color_blue="\033[34m" > fi > > strip_esc() { >
Which release is this patch based on?
This one failed to apply to linux-kselftest next - I resolved a minor merge conflict and applied it. Please review to make sure it looks good.
thanks, -- Shuah
| |