lkml.org 
[lkml]   [2019]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v7 00/23] locking/lockdep: Add support for dynamic keys
    On Fri, Feb 22, 2019 at 09:20:34AM -0800, Bart Van Assche wrote:
    > On 2/22/19 8:26 AM, Peter Zijlstra wrote:
    > > I've gone over all and I think it looks ok now; I'll give it another
    > > round tomorrow^Wmonday and then queue bits.
    > >
    > > So far the only changes I've made are the below. I'm not entirely sure
    > > on the unconditional validity check on DEBUG_LOCKDEP, maybe I'll add a
    > > boot param for that.
    >
    > Hi Peter,
    >
    > Please keep in mind that calling check_data_structures() slows down the
    > kernel a lot and also that it makes systems much less responsive. This is
    > because the consistency checks disable interrupts for a long time, up to
    > several seconds. That is why I think it should be possible to enable and
    > disable the consistency checks independent of other kernel config options.

    Ah, yes. So I had expected expensive, but hadn't tried it yet.

    I'll make it a boot option.

    \
     
     \ /
      Last update: 2019-02-22 23:14    [W:4.236 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site