lkml.org 
[lkml]   [2019]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/4] pwm: atmel: add struct atmel_pwm_data
On Tue, Feb 19, 2019 at 10:08:53AM +0000, Claudiu.Beznea@microchip.com wrote:
> From: Claudiu Beznea <claudiu.beznea@microchip.com>
>
> Add struct atmel_pwm_data to embed different per controller information. At
> this stage, embed a member of type struct atmel_pwm_registers in it.

I'd write:

Introduce a new structure to describe per controller
information. For now it contains only a struct
atmel_pwm_registers member which up to now is enough to describe
the relevant differences and was used directly as driver data
before.
This prepares adding support for another similar controller that
needs additional information.

Other than that

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |

\
 
 \ /
  Last update: 2019-02-21 21:14    [W:0.118 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site