Messages in this thread | | | Subject | Re: [PATCH v2 1/2] scsi: replace GFP_ATOMIC with GFP_KERNEL for allocations in scsi_scan.c | From | Bart Van Assche <> | Date | Thu, 21 Feb 2019 10:45:19 -0800 |
| |
On Thu, 2019-02-21 at 10:18 +0100, Benjamin Block wrote: > Looking at the code of scsi_alloc_sdev(), and all the calling contexts, > there seems to be no reason to use GFP_ATMOIC here. All the different > call-contexts use a mutex at some point, and nothing in between that > requires no sleeping, as far as I could see. Additionally, the code that > later allocates the block queue for the device (scsi_mq_alloc_queue()) > already uses GFP_KERNEL. > > > [ ... ] > > So replace all these, and give them a bit of a better chance to succeed, > with more chances of reclaim.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
| |