lkml.org 
[lkml]   [2019]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 06/23] hwmon: (lm80) Fix missing unlock on error in set_fan_div()
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit 07bd14ccc3049f9c0147a91a4227a571f981601a ]

    Add the missing unlock before return from function set_fan_div()
    in the error handling case.

    Fixes: c9c63915519b ("hwmon: (lm80) fix a missing check of the status of SMBus read")
    Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hwmon/lm80.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/hwmon/lm80.c b/drivers/hwmon/lm80.c
    index 0e30fa00204cd..f9b8e3e23a8e8 100644
    --- a/drivers/hwmon/lm80.c
    +++ b/drivers/hwmon/lm80.c
    @@ -393,8 +393,10 @@ static ssize_t set_fan_div(struct device *dev, struct device_attribute *attr,
    }

    rv = lm80_read_value(client, LM80_REG_FANDIV);
    - if (rv < 0)
    + if (rv < 0) {
    + mutex_unlock(&data->update_lock);
    return rv;
    + }
    reg = (rv & ~(3 << (2 * (nr + 1))))
    | (data->fan_div[nr] << (2 * (nr + 1)));
    lm80_write_value(client, LM80_REG_FANDIV, reg);
    --
    2.19.1


    \
     
     \ /
      Last update: 2019-02-21 15:49    [W:2.540 / U:1.600 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site