Messages in this thread | | | Date | Thu, 21 Feb 2019 14:15:14 +0000 | From | Will Deacon <> | Subject | Re: [PATCH-tip v2 04/10] locking/rwsem: Micro-optimize rwsem_try_read_lock_unqueued() |
| |
On Fri, Feb 15, 2019 at 03:50:04PM -0500, Waiman Long wrote: > The atomic_long_cmpxchg_acquire() in rwsem_try_read_lock_unqueued() is > replaced by atomic_long_try_cmpxchg_acquire() to simpify the code and > generate slightly better assembly code. There is no functional change.
Might be nice to illustrate the improvement in the commit message, but it seems that try_cmpxchg is generally preferred for x86, so:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
| |