Messages in this thread | | | Date | Thu, 21 Feb 2019 14:23:30 -0800 | From | Andi Kleen <> | Subject | Re: [PATCH 04/17] perf data: Fail check_backup in case of error |
| |
On Thu, Feb 21, 2019 at 10:41:32AM +0100, Jiri Olsa wrote: > And display the error message from removing > the old data file: > > $ perf record ls > Can't remove old data: Permission denied (perf.data.old) > Perf session creation failed. > > Not sure how to make fail the rename (after we successfully > remove the destination file/dir) to show the message, > anyway let's have it there.
The use of rm_rf is really scary. So I simple command line typo could turn this into rm -rf / ?
Please add some sanity checks to not remove multiple levels, and only remove files which look like they are generated by perf.
-Andi
| |