Messages in this thread | | | Date | Wed, 20 Feb 2019 18:07:54 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH 3/9] iio: accel: bmc150: add mount matrix support |
| |
On Wed, Feb 20, 2019 at 03:00:50PM +0100, H. Nikolaus Schaller wrote: > This patch allows to read a mount-matrix device tree > property and report to user-space or in-kernel iio > clients.
> +static const struct iio_mount_matrix * > +bmc150_accel_get_mount_matrix(const struct iio_dev *indio_dev, > + const struct iio_chan_spec *chan) > +{ > + return &((struct bmc150_accel_data *)iio_priv(indio_dev))->orientation;
It's hard to read.
Can you split such lines in your series to something like
struct bmc150_accel_data *data = iio_priv(indio_dev);
return &data->orientation;
?
> +} > + > +static const struct iio_chan_spec_ext_info bmc150_accel_ext_info[] = { > + IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, bmc150_accel_get_mount_matrix), > + { },
Terminator lines better without comma.
> +};
-- With Best Regards, Andy Shevchenko
| |