lkml.org 
[lkml]   [2019]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 3/4] perf record: enable runtime trace compression
From
Date

On 12.02.2019 16:09, Jiri Olsa wrote:
> On Mon, Feb 11, 2019 at 11:23:40PM +0300, Alexey Budankov wrote:
>
> SNIP
>
>> diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c
>> index 239e9a13c2b7..980784b77fe2 100644
>> --- a/tools/perf/util/mmap.c
>> +++ b/tools/perf/util/mmap.c
>> @@ -156,6 +156,86 @@ void __weak auxtrace_mmap_params__set_idx(struct auxtrace_mmap_params *mp __mayb
>> {
>> }
>>
>> +static ssize_t perf_mmap__capture(struct perf_mmap *md, int idx,
>> + perf_mmap__compress_fn_t compress, void *where)
>> +{
>> + u64 head = perf_mmap__read_head(md);
>> + unsigned char *data = md->base + page_size;
>> + unsigned long size, size0 = 0;
>> + void *buf;
>> + int rc = 0;
>> + size_t mmap_len = perf_mmap__mmap_len(md);
>
> again, this function seems like duplicate of perf_mmap__push,
> can't you just overload the push callback?

Answered related question in other mail.
Overloading could be an option.

Thanks,
Alexey

>
> thanks,
> jirka
>

\
 
 \ /
  Last update: 2019-02-20 16:13    [W:0.137 / U:21.116 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site