lkml.org 
[lkml]   [2019]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/4] perf record: implement -z=<level> and --mmap-flush=<thres> options
From
Date

On 12.02.2019 16:09, Jiri Olsa wrote:
> On Mon, Feb 11, 2019 at 11:22:38PM +0300, Alexey Budankov wrote:
>
> SNIP
>
>> +static int process_compressed(struct feat_fd *ff,
>> + void *data __maybe_unused)
>> +{
>> + u64 compression_info;
>> +
>> + if (do_read_u64(ff, &compression_info))
>> + return -1;
>> +
>> + ff->ph->env.comp_type = (compression_info >> 32) & 0xffffffffULL;
>> + ff->ph->env.comp_level = compression_info & 0xffffffffULL;
>> +
>> + if (do_read_u64(ff, &compression_info))
>> + return -1;
>> +
>> + ff->ph->env.comp_ratio = (compression_info >> 32) & 0xffffffffULL;
>> + ff->ph->env.comp_mmap_len = compression_info & 0xffffffffULL;
>> +
>> + return 0;
>> +}
>> +
>> struct feature_ops {
>> int (*write)(struct feat_fd *ff, struct perf_evlist *evlist);
>> void (*print)(struct feat_fd *ff, FILE *fp);
>> @@ -2651,7 +2693,8 @@ static const struct feature_ops feat_ops[HEADER_LAST_FEATURE] = {
>> FEAT_OPN(CACHE, cache, true),
>> FEAT_OPR(SAMPLE_TIME, sample_time, false),
>> FEAT_OPR(MEM_TOPOLOGY, mem_topology, true),
>> - FEAT_OPR(CLOCKID, clockid, false)
>> + FEAT_OPR(CLOCKID, clockid, false),
>> + FEAT_OPR(COMPRESSED, compressed, false)
>
> please separate the COMPRESSED feature ddition into single patch

Moved to a separate patch.

Thanks,
Alexey

>
> thanks,
> jirka
>

\
 
 \ /
  Last update: 2019-02-20 15:26    [W:0.127 / U:7.332 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site