lkml.org 
[lkml]   [2019]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec
    From
    Date
    On 2/20/19 2:11 PM, Nick Crews wrote:
    > In the initial version of the Wilco EC Driver, the
    > dependency order was wrong. It before was possible to
    > select CONFIG_WILCO_EC and CONFIG_CROS_EC_LPC without
    > having CONFIG_CROS_EC_LPC_MEC. This was wrong, since
    > WILCO_EC depends upon CONFIG CROS_EC_LPC_MEC, not the
    > other way around.
    >
    > Fixes: 1733c32834e5d1 ("platform/chrome: Add new driver for Wilco EC")
    > Signed-off-by: Nick Crews <ncrews@chromium.org>

    Reported-by: Randy Dunlap <rdunlap@infradead.org>
    Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

    Thanks.

    > ---
    > drivers/platform/chrome/Kconfig | 2 +-
    > drivers/platform/chrome/wilco_ec/Kconfig | 3 +--
    > 2 files changed, 2 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
    > index 462eb9dfa4f2..b69561050868 100644
    > --- a/drivers/platform/chrome/Kconfig
    > +++ b/drivers/platform/chrome/Kconfig
    > @@ -95,7 +95,7 @@ config CROS_EC_LPC
    >
    > config CROS_EC_LPC_MEC
    > bool "ChromeOS Embedded Controller LPC Microchip EC (MEC) variant"
    > - depends on CROS_EC_LPC || WILCO_EC
    > + depends on CROS_EC_LPC
    > default n
    > help
    > If you say Y here, a variant LPC protocol for the Microchip EC
    > diff --git a/drivers/platform/chrome/wilco_ec/Kconfig b/drivers/platform/chrome/wilco_ec/Kconfig
    > index 20945a301ec6..c6bc4e8f3062 100644
    > --- a/drivers/platform/chrome/wilco_ec/Kconfig
    > +++ b/drivers/platform/chrome/wilco_ec/Kconfig
    > @@ -1,7 +1,6 @@
    > config WILCO_EC
    > tristate "ChromeOS Wilco Embedded Controller"
    > - depends on ACPI && X86
    > - select CROS_EC_LPC_MEC
    > + depends on ACPI && X86 && CROS_EC_LPC_MEC
    > help
    > If you say Y here, you get support for talking to the ChromeOS
    > Wilco EC over an eSPI bus. This uses a simple byte-level protocol
    >


    --
    ~Randy

    \
     
     \ /
      Last update: 2019-02-21 00:11    [W:4.278 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site