Messages in this thread | | | Date | Tue, 19 Feb 2019 09:58:14 -0800 | From | Tony Lindgren <> | Subject | Re: [PATCH] arm/mach-omap2/display: fix possible object reference leak |
| |
* Julia Lawall <julia.lawall@lip6.fr> [190219 17:33]: > On Tue, 19 Feb 2019, Tony Lindgren wrote: > > In general, if the device tree node is never used afterwards, > > should this be just: > > > > r = of_platform_populate(node, NULL, NULL, &pdev->dev); > > of_node_put(dev_node); > > if (r) { > > ... > > } > > > > If so, Julia might have a Coccinelle recpipe for it? > > Unfortunately this is not really an ideal case for Coccinelle, because > node is the result of calling a local function and Coccinelle doesn't by > default do any interprocedural analysis. It is possible to write a rule > that explicitly looks for one function that returns a device node and then > the pattern of its usage in the caller, though.
OK thanks for the information.
Regards,
Tony
| |