lkml.org 
[lkml]   [2019]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 05/10] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings
    * Lokesh Vutla <lokeshvutla@ti.com> [190219 16:19]:
    > yes. How different is this from any of the above mentioned drivers using
    > firmware specific ids. Like sci pm domain[1] driver utilizes the same
    > device id for enabling any device in the system. Similarly clock
    > driver[2] uses the same device ids and clock ids specified by firmware.
    > There are more which similarly represents firmware ids from DT.
    >
    > [1] Documentation/devicetree/bindings/soc/ti/sci-pm-domain.txt
    > [2] Documentation/devicetree/bindings/clock/ti,sci-clk.txt

    That's horrible. We really must not use any firmware invented
    numbers in the device as they do not describe hardware.

    Regards,

    Tony

    \
     
     \ /
      Last update: 2019-02-19 18:13    [W:7.088 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site