lkml.org 
[lkml]   [2019]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v6 1/7] irq/irq_sim: add irq_set_type() callback
wt., 19 lut 2019 o 17:14 Marc Zyngier <marc.zyngier@arm.com> napisał(a):
>
> On Tue, 19 Feb 2019 17:06:44 +0100
> Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > Implement the irq_set_type() callback and call irqd_set_trigger_type()
> > internally so that users interested in the configured trigger type can
> > later retrieve it using irqd_get_trigger_type(). We only support edge
> > trigger types.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > ---
> > kernel/irq/irq_sim.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/kernel/irq/irq_sim.c b/kernel/irq/irq_sim.c
> > index 98a20e1594ce..b992f88c5613 100644
> > --- a/kernel/irq/irq_sim.c
> > +++ b/kernel/irq/irq_sim.c
> > @@ -25,10 +25,22 @@ static void irq_sim_irqunmask(struct irq_data *data)
> > irq_ctx->enabled = true;
> > }
> >
> > +static int irq_sim_set_type(struct irq_data *data, unsigned int type)
> > +{
> > + /* We only support rising and falling edge trigger types. */
> > + if (type & ~IRQ_TYPE_EDGE_BOTH)
> > + return -EINVAL;
> > +
> > + irqd_set_trigger_type(data, type);
> > +
> > + return 0;
> > +}
> > +
> > static struct irq_chip irq_sim_irqchip = {
> > .name = "irq_sim",
> > .irq_mask = irq_sim_irqmask,
> > .irq_unmask = irq_sim_irqunmask,
> > + .irq_set_type = irq_sim_set_type,
> > };
> >
> > static void irq_sim_handle_irq(struct irq_work *work)
>
> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
>

Thanks you! If you don't mind, I'll send this together with other
patches directly to Linus Walleij.

Bartosz

\
 
 \ /
  Last update: 2019-02-19 17:37    [W:0.035 / U:64.408 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site