Messages in this thread | | | From | Steve Twiss <> | Subject | RE: [PATCH 1/2] regulator: da9062: Select maximum current in specific range for set_current_limit | Date | Tue, 19 Feb 2019 14:05:11 +0000 |
| |
Hi Axel,
On 19 February 2019 13:31, Axel Lin wrote:
> To: Mark Brown <broonie@kernel.org> > Subject: [PATCH 1/2] regulator: da9062: Select maximum current in specific range for set_current_limit > > Selecting the minimal value is only true for voltage regulators. > For current regulators the maximum in the given range should be > selected instead. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > drivers/regulator/da9062-regulator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/regulator/da9062-regulator.c b/drivers/regulator/da9062- > regulator.c > index d06e9600fa18..4c5d6ad853f8 100644 > --- a/drivers/regulator/da9062-regulator.c > +++ b/drivers/regulator/da9062-regulator.c > @@ -126,7 +126,7 @@ static int da9062_set_current_limit(struct regulator_dev > *rdev, > const struct da9062_regulator_info *rinfo = regl->info; > int n, tval; > > - for (n = 0; n < rinfo->n_current_limits; n++) { > + for (n = rinfo->n_current_limits - 1; n >= 0; n--) { > tval = rinfo->current_limits[n]; > if (tval >= min_ua && tval <= max_ua) > return regmap_field_write(regl->ilimit, n); > -- > 2.17.1
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
Thanks and regards, Steve
| |