lkml.org 
[lkml]   [2019]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tty: not call tty close in fallback
On Mon, Jan 14, 2019 at 02:56:01PM +0800, yes wrote:
> From: Li RongQing <lirongqing@baidu.com>
>
> when fail to open tty, tty is not in open status and not need
> to call close
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> ---
> drivers/tty/serdev/serdev-ttyport.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c
> index fa1672993b4c..bcc1e27d00de 100644
> --- a/drivers/tty/serdev/serdev-ttyport.c
> +++ b/drivers/tty/serdev/serdev-ttyport.c
> @@ -121,7 +121,7 @@ static int ttyport_open(struct serdev_controller *ctrl)
>
> ret = tty->ops->open(serport->tty, NULL);
> if (ret)
> - goto err_close;
> + goto err_unlock;
>
> tty_unlock(serport->tty);
>
> @@ -142,8 +142,6 @@ static int ttyport_open(struct serdev_controller *ctrl)
>
> return 0;
>
> -err_close:
> - tty->ops->close(tty, NULL);

No, close is always called after open, even if open fails.

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-02-19 13:42    [W:0.031 / U:22.852 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site