Messages in this thread | | | Date | Tue, 19 Feb 2019 17:44:20 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH v10 1/3] dmaengine: 8250_mtk_dma: add MediaTek uart DMA support |
| |
On 14-02-19, 10:44, Long Cheng wrote: > On Mon, 2019-02-04 at 12:51 +0530, Vinod Koul wrote:
> > > +static int mtk_uart_apdma_device_pause(struct dma_chan *chan) > > > +{ > > > + /* just for check caps pass */ > > > + return 0; > > > +} > > > > please remove, this is not a mandatory fn > > Can't remove it. Before the mail, i had explained it. in 8250 uart > framework, will check the function..
I think you should fix the 8250 uart to handle driver not having a pause. Keeping a dummy pause is just wrong and sets wrong expectations for uart..
-- ~Vinod
| |