lkml.org 
[lkml]   [2019]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 13/15] ARM: dts: milbeaut: Add device tree set for the Milbeaut M10V board
From
Date
Hi,
Thank you for you comments.

On 2019/02/18 21:09, Arnd Bergmann wrote:
> On Fri, Feb 8, 2019 at 1:28 PM Sugaya Taichi
> <sugaya.taichi@socionext.com> wrote:
>> +
>> + aliases {
>> + serial1 = &uart1;
>> + };
>
> Maybe start with serial0 here? It seems unusual to start
> counting at 1.
>

The M10V evaluation board(EVB) uses a console with uart ch1, so this
alias number is derived from the used channel one.
Therefore it is no problem to change the alias number to 0.

>> + chosen {
>> + bootargs = "init=/sbin/finit rootwait earlycon";
>
> The /sbin/finit argument seems user space specific, so you probably don't
> want this in the dts file but rather pass it from the boot loader.
> Possible drop the bootargs entirely.
>

Okay, remove the arg from the dts and add to bootargs instead.

Thanks,
Sugaya Taichi

> Arnd
>

\
 
 \ /
  Last update: 2019-02-19 06:13    [W:0.088 / U:17.576 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site