Messages in this thread | | | Subject | Re: [PATCH v2 09/15] dt-bindings: serial: Add Milbeaut serial driver description | From | "Sugaya, Taichi" <> | Date | Tue, 19 Feb 2019 17:11:29 +0900 |
| |
Hi,
On 2019/02/19 4:57, Rob Herring wrote: > On Fri, Feb 08, 2019 at 09:27:29PM +0900, Sugaya Taichi wrote: >> Add DT bindings document for Milbeaut serial driver. >> >> Signed-off-by: Sugaya Taichi <sugaya.taichi@socionext.com> >> --- >> .../devicetree/bindings/serial/milbeaut-uart.txt | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/serial/milbeaut-uart.txt >> >> diff --git a/Documentation/devicetree/bindings/serial/milbeaut-uart.txt b/Documentation/devicetree/bindings/serial/milbeaut-uart.txt >> new file mode 100644 >> index 0000000..8f61c38 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/serial/milbeaut-uart.txt >> @@ -0,0 +1,21 @@ >> +Socionext Milbeaut UART controller >> + >> +Required properties: >> +- compatible: should be "socionext,milbeaut-usio-uart". >> +- reg: offset and length of the register set for the device. >> +- interrupts: two interrupts specifier. >> +- clocks: phandle to the input clock. >> +- interrupt-names: should be "rx", "tx". > > Put this next to 'interrupts' >
OK, change the order.
>> + >> +Optional properties: >> +- uart-flow-enable: flow control enable. > > We already have a standard property for this: auto-flow-control >
Okay, I change the property name to "auto-flow-control"
>> + >> +Example: >> + usio1: usio_uart@1e700010 { > > serial@... >
I got it.
Thanks, Sugaya Taichi
>> + compatible = "socionext,milbeaut-usio-uart"; >> + reg = <0x1e700010 0x10>; >> + interrupts = <0 141 0x4>, <0 149 0x4>; >> + interrupt-names = "rx", "tx"; >> + clocks = <&clk 2>; >> + uart-flow-enable; >> + }; >> -- >> 1.9.1 >>
| |