lkml.org 
[lkml]   [2019]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V6 1/4] dt-bindings: fsl: scu: add thermal binding
Date
> From: Anson Huang
> Sent: Thursday, February 7, 2019 5:53 PM
[...]
>
> NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system
> controller, the system controller is in charge of system power, clock and
> thermal sensors etc. management, Linux kernel has to communicate with
> system controller via MU (message unit) IPC to get temperature from thermal
> sensors, this patch adds binding doc for i.MX system controller thermal driver.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> ChangeLog since V5:
> - add "imx,sensor-resource-id" in each thermal zone to pass resource ID
> for thermal driver.
> ---
> .../devicetree/bindings/arm/freescale/fsl,scu.txt | 20
> ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index 72d481c..4b79751 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -122,6 +122,20 @@ RTC bindings based on SCU Message Protocol
> Required properties:
> - compatible: should be "fsl,imx8qxp-sc-rtc";
>
> +Thermal bindings based on SCU Message Protocol
> +------------------------------------------------------------
> +
> +Required properties:
> +- compatible : Must be "fsl,imx8qxp-sc-thermal";
> +- tsens-num : Total number of thermal sensors supported;
> +- #thermal-sensor-cells : Should be 1. See
> + Documentation/devicetree/bindings/thermal/thermal.txt
> + for a description.
> +- imx,sensor-resource-id : This property should be defined in each thermal
> zone
> + of thermal-zones node, it passes each thermal zone's
> + resource id for thermal driver to get temperature via
> + SCU IPC.

This is missing in the example?

BTW, is this SCU function likely platform dependent?
If not, you probably could add a fallback compatible such as "fsl,scu-rtc"

Regards
Dong Aisheng

> +
> Example (imx8qxp):
> -------------
> lsio_mu1: mailbox@5d1c0000 {
> @@ -168,6 +182,12 @@ firmware {
> rtc: rtc {
> compatible = "fsl,imx8qxp-sc-rtc";
> };
> +
> + tsens: thermal-sensor {
> + compatible = "fsl,imx8qxp-sc-thermal";
> + tsens-num = <1>;
> + #thermal-sensor-cells = <1>;
> + };
> };
> };
>
> --
> 2.7.4

\
 
 \ /
  Last update: 2019-02-20 04:27    [W:0.091 / U:11.004 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site