Messages in this thread | | | Subject | Re: [PATCH 03/13] mm: Add generic p?d_large() macros | From | Steven Price <> | Date | Mon, 18 Feb 2019 14:20:09 +0000 |
| |
On 18/02/2019 12:53, Peter Zijlstra wrote: > On Mon, Feb 18, 2019 at 11:14:23AM +0000, Mark Rutland wrote: >>> +#ifndef pgd_large >>> +#define pgd_large(x)0 >>> +#endif >>> +#ifndef pud_large >>> +#define pud_large(x)0 >>> +#endif >>> +#ifndef pmd_large >>> +#define pmd_large(x)0 >>> +#endif >> >> It might be worth a comment defining the semantics of these, e.g. how >> they differ from p?d_huge() and p?d_trans_huge(). > > Yes; I took it to mean any large page mapping, so it would explicitly > include huge and thp.
Yes your interpretation is correct. I'll add a comment explaining the semantics.
Thanks,
Steve
| |