lkml.org 
[lkml]   [2019]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH net-next v3 04/21] ethtool: helper functions for netlink interface
On Mon, 18 Feb 2019 19:21:44 +0100 (CET), Michal Kubecek wrote:
> +/* create skb for a reply and fill device identification
> + * payload: payload length (without netlink and genetlink header)
> + * dev: device the reply is about (may be null)
> + * cmd: ETHNL_CMD_* command for reply
> + * info: info for the received packet we respond to
> + * ehdrp: place to store payload pointer returned by genlmsg_new()
> + * returns: skb or null on error
> + */

nit: why not correct kdoc?

> +struct sk_buff *ethnl_reply_init(size_t payload, struct net_device *dev, u8 cmd,
> + u16 dev_attrtype, struct genl_info *info,
> + void **ehdrp)
> +{
> + void *ehdr;
> + struct sk_buff *rskb;

nit: reverse xmas tree

\
 
 \ /
  Last update: 2019-02-18 21:15    [W:0.159 / U:4.296 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site