Messages in this thread | | | Subject | Re: [PATCH] watchdog: pc87413: Mark expected switch fall-through | From | Guenter Roeck <> | Date | Mon, 18 Feb 2019 08:09:17 -0800 |
| |
On 2/14/19 12:26 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/watchdog/pc87413_wdt.c: In function ‘pc87413_ioctl’: > drivers/watchdog/pc87413_wdt.c:439:3: warning: this statement may fall through [-Wimplicit-fallthrough=] > pc87413_refresh(); > ^~~~~~~~~~~~~~~~~ > drivers/watchdog/pc87413_wdt.c:441:2: note: here > case WDIOC_GETTIMEOUT: > ^~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > Notice that, in this particular case, the code comment is modified > in accordance with what GCC is expecting to find. > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> --- > drivers/watchdog/pc87413_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/pc87413_wdt.c b/drivers/watchdog/pc87413_wdt.c > index 06a892e36a8d..2ffa39b46970 100644 > --- a/drivers/watchdog/pc87413_wdt.c > +++ b/drivers/watchdog/pc87413_wdt.c > @@ -437,7 +437,7 @@ static long pc87413_ioctl(struct file *file, unsigned int cmd, > return -EINVAL; > timeout = new_timeout; > pc87413_refresh(); > - /* fall through and return the new timeout... */ > + /* fall through - and return the new timeout... */ > case WDIOC_GETTIMEOUT: > new_timeout = timeout * 60; > return put_user(new_timeout, uarg.i); >
| |