lkml.org 
[lkml]   [2019]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] watchdog: smsc37b787_wdt: Mark expected switch fall-through
From
Date
On 2/14/19 12:16 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/watchdog/smsc37b787_wdt.c: In function ‘wb_smsc_wdt_ioctl’:
> drivers/watchdog/smsc37b787_wdt.c:480:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> wb_smsc_wdt_set_timeout(timeout);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/watchdog/smsc37b787_wdt.c:482:2: note: here
> case WDIOC_GETTIMEOUT:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> drivers/watchdog/smsc37b787_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/smsc37b787_wdt.c b/drivers/watchdog/smsc37b787_wdt.c
> index 445ea1ad1fa9..c768dcd53034 100644
> --- a/drivers/watchdog/smsc37b787_wdt.c
> +++ b/drivers/watchdog/smsc37b787_wdt.c
> @@ -478,7 +478,7 @@ static long wb_smsc_wdt_ioctl(struct file *file,
> return -EINVAL;
> timeout = new_timeout;
> wb_smsc_wdt_set_timeout(timeout);
> - /* fall through and return the new timeout... */
> + /* fall through - and return the new timeout... */
> case WDIOC_GETTIMEOUT:
> new_timeout = timeout;
> if (unit == UNIT_MINUTE)
>

\
 
 \ /
  Last update: 2019-02-18 17:08    [W:0.081 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site