Messages in this thread | | | Subject | Re: [PATCH 01/13] arm64: mm: Add p?d_large() definitions | From | Steven Price <> | Date | Mon, 18 Feb 2019 15:30:38 +0000 |
| |
On 18/02/2019 15:06, Peter Zijlstra wrote: > On Mon, Feb 18, 2019 at 02:29:52PM +0000, Mark Rutland wrote: >> I think that Peter means p?d_huge(x) should imply p?d_large(x), e.g. >> >> #define pmd_large(x) \ >> (pmd_sect(x) || pmd_huge(x) || pmd_trans_huge(x)) >> >> ... which should work regardless of CONFIG_HUGETLB_PAGE. > > Yep, that.
I'm not aware of a situation where pmd_huge(x) is true but pmd_sect(x) isn't. Equally for pmd_huge(x) and pmd_trans_huge(x).
What am I missing?
Steve
| |