| Subject | Re: [PATCH v4 33/37] ARM: davinci: cp-intc: use readl/writel_relaxed() | From | David Lechner <> | Date | Sun, 17 Feb 2019 11:01:05 +0100 |
| |
On 2/14/19 8:52 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > Raplace all calls to __raw_readl() & __raw_writel() with readl_relaxed()
s/Raplace/Replace/
> and writel_relaxed() respectively. It's safe to do as there's no > endianness conversion being done in the code.
Should this be combined with patch 14/37?
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > arch/arm/mach-davinci/cp_intc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-davinci/cp_intc.c b/arch/arm/mach-davinci/cp_intc.c > index 1bf11fa8be76..f88b7f0978aa 100644 > --- a/arch/arm/mach-davinci/cp_intc.c > +++ b/arch/arm/mach-davinci/cp_intc.c > @@ -45,13 +45,13 @@ static struct irq_domain *davinci_cp_intc_irq_domain; > > static inline unsigned int davinci_cp_intc_read(unsigned int offset) > { > - return __raw_readl(davinci_cp_intc_base + offset); > + return readl_relaxed(davinci_cp_intc_base + offset); > } > > static inline void davinci_cp_intc_write(unsigned long value, > unsigned int offset) > { > - __raw_writel(value, davinci_cp_intc_base + offset); > + writel_relaxed(value, davinci_cp_intc_base + offset); > } > > static void davinci_cp_intc_ack_irq(struct irq_data *d) >
|