Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH] powerpc/64s: Fix possible corruption on big endian due to pgd/pud_present() | Date | Sun, 17 Feb 2019 19:26:29 +1100 |
| |
Andreas Schwab <schwab@linux-m68k.org> writes:
> On Feb 14 2019, Michael Ellerman <mpe@ellerman.id.au> wrote: > >> The fix is simple, we need to convert the result of the bitwise && to >> an int before returning it. > > Alternatively, the return type could be changed to bool, so that the > compiler does the right thing by itself.
Yes that would be preferable. All other architectures return an int so I wasn't game to switch to bool for a fix. But I don't see why it should matter so I'll do a patch using bool for next.
cheers
| |